Implement operator== for license struct #8195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes bug due to operator== being called on the inherited serde::envelope struct which will always return true. - Deletes spacheship operator overload as it could result in the same bug and it is currently not called on this type
graphcareful
requested review from
patrickangeles,
dotnwat,
jcsp and
michael-redpanda
graphcareful
force-pushed
the
put-license-fix
branch
from
520663c
to
57c5dff
Compare
|
Looks like the license test is failing test_id: rptest.tests.rpk_cluster_test.RpkClusterTest.test_upload_and_query_cluster_license_rpk |
graphcareful
force-pushed
the
put-license-fix
branch
from
57c5dff
to
eac3111
Compare
|
Tests have been fixed, all license tests pass on CI |
andrwng
approved these changes
Jan 14, 2023
andrwng
reviewed
Jan 14, 2023
dotnwat
approved these changes
Jan 14, 2023
|
/backport v22.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for an issue that manifested to a customer in newer versions of redpanda, where licenses could not be re-uploaded. The cause occurres when comparing two
security::licenses via operator==, where this method was actually called on the superclass ofsecurity::licensewhich isserde::envelope. The envelopes will always be the same in the scenario, so this comparison would always returntrue, preventing users from uploading newer licenses.The fix is to correctly implement
operator==forsecurity::license.Backports Required
Release Notes
Bug Fixes