Fixed tracking decommissioned update revision in cluster::members_backend
#8245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Maslanka <michal@redpanda.com>
When operation is already finished as the node was removed we may exit early instead of going through the whole members_backend reconciliation logic. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Members backend was tracking last node decommission revision to be able to cancel all related partition movements. The tracking was broken as it might be the case that the revision map was updated by the next decommission update while the previous recommission was still being processed. In order to fix this issue and simplify tracking of last decommission revision id introduced tracking previous decommission revision inside of recommission update metadata object. This way a certain recommission action is always related with correct decommission revision. Fixes: redpanda-data#8218 Signed-off-by: Michal Maslanka <michal@redpanda.com>
ztlpn
approved these changes
Jan 16, 2023
|
/backport v22.3.x |
|
The pull request is not merged yet. Cancelling backport... |
|
/backport v22.3.x |
|
Failed to run cherry-pick command. I executed the below command: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Members backend was tracking last node decommission revision to be able
to cancel all related partition movements. The tracking was broken as it
might be the case that the revision map was updated by the next
decommission update while the previous recommission was still being
processed. In order to fix this issue and simplify tracking of last
decommission revision id introduced tracking previous decommission
revision inside of recommission update metadata object. This way a
certain recommission action is always related with correct decommission
revision.
Fixes: #8218
Backports Required
UX Changes
Release Notes
Bug Fixes