Return not leader for partition when shard is not found #8387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving partition the metadata may not reflect the actual replica placement as the actual data movement may take time. If partition metadata is correct but the partition not yet exists on a node we must return retryable error to the client. There is a possibility that during handling next client request partition will already be available on the node. Changed error returned when partition shard wasn't found from `UNKNOWN_TOPIC_OR_PARTITION` which is not retryable to `NOT_LEADER_FOR_PARTITION` which forces producer to retry. Fixes: redpanda-data#8290 Signed-off-by: Michal Maslanka <michal@redpanda.com>
graphcareful
approved these changes
Jan 24, 2023
NyaliaLui
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving partition the metadata may not reflect the actual replica placement as the actual data movement may take time. If partition metadata is correct but the partition not yet exists on a node we must return retryable error to the client. There is a possibility that during handling next client request partition will already be available on the node.
Changed error returned when partition shard wasn't found from
UNKNOWN_TOPIC_OR_PARTITIONwhich is not retryable toNOT_LEADER_FOR_PARTITIONwhich forces producer to retry.Fixes: #8290
Backports Required
UX Changes
Release Notes
Bug Fixes