support for definining cmd arguments

[koikonom]

Sometimes we need to pass new command line arguments to Redpanda, in order to enable functionality not necessarily managed by the Cluster spec. This PR adds a new field in the spec that allows us to do just that. For example a cluster spec that would use this feature would look like this:

apiVersion: redpanda.vectorized.io/v1alpha1
kind: Cluster
metadata:
  name: test-cluster
spec:
[... other ...]
  configuration:
    [... other ...]
    additionalCommandlineArguments:
      overprovisioned: ""
      default-log-level: "info"

Backports Required

• none - not a bug fix
• none - issue does not exist in previous branches
• none - papercut/not impactful enough to backport
• v22.3.x
• v22.2.x
• v22.1.x

Release Notes

Improvements

• Added a new field called additionalCommandlineArguments under the configuration block that allows additional command line arguments to be passed to the redpanda command line.

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[RafalKorepta]

I see you need to sign CLA, write at least one unit test that uses additional command line flags and last but not least change the PR cover letter as release notes will not be rendered correctly.

[0xdiba]

LGTM 🚀
Let's wait for @RafalKorepta (or the @redpanda-data/k8s team in general) to give the final 👍

[RafalKorepta]

Could you add one e2e test?

[esteban]

Retrying failed tests.

[esteban]

Not in the full scope of this e2e test but it would be better if we could confirm if the redpanda command includes the new flags and not just if the container was launched. I think if we can confirm that it does apply the flags correctly that should be enough for now.

[koikonom]

I'd expect this to be covered in the rest of the testing suite. See here for example: https://github.com/redpanda-data/redpanda/pull/8401/files#diff-0cfeba1779bdecfec8476b8602a73be2ab7de5892aec5463b2866bc66f4b42b2R805

[RafalKorepta]

This should be moved to 00-assert.yaml as we need to wait for cluster to report configured condition.

[RafalKorepta]

Because of this change linter stated to complain:

pkg/resources/ingress.go:99:68: string `true` has 2 occurrences, make it a constant (goconst)
--
  | r.annotations["nginx.ingress.kubernetes.io/force-ssl-redirect"] = "true"

https://buildkite.com/redpanda/redpanda/builds/22710#01862dcd-a745-4e05-adec-77c7ba803d1e/408-477

[koikonom]

sorted