Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: Fix secret shared between e2e tests #8648

Merged

Conversation

RafalKorepta
Copy link
Contributor

@RafalKorepta RafalKorepta commented Feb 6, 2023

The flakynest in the following tests were caused by parallerisation runs:

  • update-image-and-node-port
  • update-image-tls
  • update-image-tls-client-auth

Each tests tries to verify if secret reference for cloud storage config works as expected. Secret was put in default namespace with the same name. Now names changed to be dedicated per test.

Previously test reported the following log line in the operator logs:

2023-02-06T10:53:23.704263943Z stderr F 1.6756808037041028e+09	ERROR	controllers.redpanda.Cluster	Failed to reconcile resource	{"redpandacluster": "kuttl-test-selected-buck/up-img", "error": "unable to construct object: cannot retrieve cloud storage secret for data archival: Secret \"archival\" not found"}

https://buildkite.com/organizations/redpanda/analytics/suites/redpanda/runs/f60ee633-0997-40a5-8c50-80f0a48a8e8b
https://buildkite.com/organizations/redpanda/analytics/suites/redpanda/runs/746e89f0-5bff-4f83-ad34-cb00fcda4656
https://buildkite.com/organizations/redpanda/analytics/suites/redpanda/runs/7f203e10-fb6c-4ffd-9e48-9df82062ad94

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

None

Release Notes

Bug Fixes

  • Fix flakiness of operator e2e tests.

The flakynest in the following tests were caused by parallerisation runs:
* update-image-and-node-port
* update-image-tls
* update-image-tls-client-auth

Each tests tries to verify if secret reference for cloud storage config works
as expected. Secret was put in default namespace with the same name. Now names
changed to be dedicated per test.

Previously test reported the following log line in the operator logs:
```
2023-02-06T10:53:23.704263943Z stderr F 1.6756808037041028e+09	ERROR	controllers.redpanda.Cluster	Failed to reconcile resource	{"redpandacluster": "kuttl-test-selected-buck/up-img", "error": "unable to construct object: cannot retrieve cloud storage secret for data archival: Secret \"archival\" not found"}
```
@RafalKorepta RafalKorepta requested a review from a team as a code owner February 6, 2023 16:20
Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! lgtm

@RafalKorepta RafalKorepta merged commit e217071 into redpanda-data:dev Feb 6, 2023
@vshtokman
Copy link
Contributor

/backport v22.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants