Remove duplicate responses sent by offset_fetch request handler #8689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This request handler returns a response that contains an array of topics and within each topic, another array of partitions. - Within each array of partitions, a duplicate entry was being created, since push_back was invoked right after emplace_back, twice for each iteration of the loop to intitialize all partitions.
graphcareful
requested review from
dotnwat,
BenPope,
NyaliaLui and
michael-redpanda
BenPope
approved these changes
Feb 7, 2023
NyaliaLui
approved these changes
Feb 7, 2023
|
/backport v22.3.x |
|
Failed to run cherry-pick command. I executed the below command: |
|
@vshtokman probably a merge conflict. author (or someone) will need to do the backport manually. |
graphcareful
added a commit
that referenced
this pull request
Feb 10, 2023
[v22.3.x] Backport of #8689 Remove duplicate responses sent by offset_fetch request handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request handler returns a response that contains an array of topics and within each topic, another array of partitions.
Within each array of partitions, a duplicate entry was being created, since push_back was invoked right after emplace_back, twice for each iteration of the loop to intitialize all partitions.
Backports Required
Release Notes
Bug Fixes