Use raft disk i/o timeout in recovery stm #8741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Maslanka <michal@redpanda.com>
We saw an intermittent hang when reading batches in recovery stm. Added a timeout when reading batches to send to the follower. When timeout occur an error is logged. This way it will be easier to track the issue in tests and real deployments. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Some tests use SIGSTOP to suspend nodes. In this case the raft I/O timeout must be longer than max suspend time as otherwise it would generate spurious failures. Signed-off-by: Michal Maslanka <michal@redpanda.com>
|
new unrelated ci failure: #8745 |
ztlpn
approved these changes
Feb 9, 2023
| std::move(gap_filled_batches)); | ||
| } catch (const ss::timed_out_error& e) { | ||
| vlog( | ||
| _ctxlog.error, |
There was a problem hiding this comment.
Recovery will be retried after this error, right? If so, what is the rationale for logging it at error severity? So that we can catch it in tests?
There was a problem hiding this comment.
exactly, i would love this to be as visible as possible.
bharathv
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw an intermittent hang when reading batches in recovery stm. Added
a timeout when reading batches to send to the follower. When timeout
occur an error is logged. This way it will be easier to track the issue
in tests and real deployments.
Fixes: #8724
Backports Required
UX Changes
Release Notes
Improvements