fixed serialization of mixed failed and successful heartbeat replies #8781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
previously approved these changes
Feb 10, 2023
When there was one failed heartbeat reply in the array of heartbeat replies it might cause all other heartbeats to fail as the not initialized field for target node_id was used for all of the heartbeat replies. Heartbeat reply serialization uses a varint delta encoding to minimize the size of exchanged messages and de-duplicate information. Changed the way how the target_node_id field is selected for serialization. Instead of using just a first node we will use last one after the array of responses is sorted for delta encoding. After sort operation the largest value of `last_flushed_offset` is at the end of the array as not initialized value is a `model::offset::min()` if there is any other value available it will reside at the end of the array after the sort. Fixes: redpanda-data#8733 Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
fix-8733
branch
from
2350c54
to
c294827
Compare
ztlpn
approved these changes
Feb 10, 2023
|
/backport v22.3.x |
|
/backport v22.2.x |
This was referenced Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there was one failed heartbeat reply in the array of heartbeat
replies it might cause all other heartbeats to fail as the not
initialized field for target node_id was used for all of the heartbeat
replies. Heartbeat reply serialization uses a varint delta encoding to
minimize the size of exchanged messages and de-duplicate information.
Changed the way how the target_node_id field is selected for
serialization. Instead of using just a first node we will use last one
after the array of responses is sorted for delta encoding. After sort
operation the largest value of
last_flushed_offsetis at the end ofthe array as not initialized value is a
model::offset::min()if thereis any other value available it will reside at the end of the array
after the sort.
Backports Required
UX Changes
Release Notes
Bug Fixes