schema_registry/protobuf: Early exit recursion if file exists #8789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During a depth-first search for references, it's possible for a reference to be looked up and added to the `DescriptorPool` multiple times, which fails. If the `DescriptorPool` contains the reference already, early exit without a looking up the referenced schema, and adding it to the dp. Signed-off-by: Ben Pope <ben@redpanda.com>
|
Known CI Failure: #8595 |
|
/backport v22.3.x |
|
/backport v22.2.x |
|
/backport v22.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a depth-first search for references, it's possible for a reference to be looked up and added to the
DescriptorPoolmultiple times, which fails.If the
DescriptorPoolcontains the reference already, early exit without a looking up the referenced schema, and adding it to the dp.Signed-off-by: Ben Pope ben@redpanda.com
Backports Required
UX Changes
Release Notes
Bug Fixes