archival: always use last_offset if available to schedule uploads #8968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrwng
force-pushed
the
translation_error
branch
from
6c77daf
to
33970b0
Compare
We previously predicated on whether there were existing segments to
choose an upload start offset. This wouldn't work in cases where the
manifest is entirely truncated away.
Without this, once attempting to upload after GCing all cloud segments,
we could end up with errors like:
```
ERROR 2023-02-16 22:54:19,549 [shard 14] archival - [fiber51 kafka/scale_000000/165] - ntp_archiver_service.cc:184 - upload loop error: std::runtime_error (ntp {kafka/scale_000000/165}: log offset 4085 is outside the translation range (starting at 8830))
```
Fixes redpanda-data#8945
andrwng
force-pushed
the
translation_error
branch
from
33970b0
to
6dd451d
Compare
Lazin
approved these changes
Feb 17, 2023
|
CI failure is #8758 |
|
/backport v22.3.x |
|
/backport v22.2.x |
|
/backport v22.1.x |
|
Failed to run cherry-pick command. I executed the below command: |
|
Failed to run cherry-pick command. I executed the below command: |
|
Failed to run cherry-pick command. I executed the below command: |
6 tasks
This was referenced Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously predicated on whether there were existing segments to choose an upload start offset. This wouldn't work in cases where the manifest is entirely truncated away.
Without this, once attempting to upload after GCing all cloud segments, we could end up with errors like:
Fixes #8945
Backports Required
UX Changes
Release Notes
Bug Fixes