[backport] [23.1.x] rm_stm: replace std::vector usage with fragmented_vector #9626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds additional typedefs for vector compatibility. - Implement front() - Make push_back() accept a forwarding reference. - Defines a custom move c-tor / assignment that guarantees empty() after move similar to std::vector. (cherry picked from commit c7dea50)
Uses the same underlying serialization as std::vector for compatibility. Adds a bounds check to limit vector size to int32_t_max which was an implicit assumption but a vector can be much bigger. (cherry picked from commit 1a5dde7)
(cherry picked from commit 89e2b17)
Addressing some comments post merge. (cherry picked from commit a24e608)
bharathv
changed the title
|
CI is green but doing another |
|
/ci-repeat 3 |
rystsov
approved these changes
Mar 23, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of state in rm_stm is backed by std::vector. With frequent snapshotting + non trivial pid counts large contiguous allocations cannot be satisfied if the memory is fragmented. This patch switches to using fragmented_vector for this usecase.
Backports Required
Release Notes
Improvements