Final fixups for ossl #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added __builtin_unreachable in the tls_version operator<< function to handle compiler error with gcc11 Signed-off-by: Michael Boquard <michael@redpanda.com>
gcc11 complained about signed vs unsigned compariso Signed-off-by: Michael Boquard <michael@redpanda.com>
gcc11 complained about signed vs unsigned comparision Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
requested review from
pgellert and
BenPope
and removed request for
a team
pgellert
previously approved these changes
Jun 6, 2024
BenPope
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Could you throw one of these on, too:
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 74242767..e976f8b7 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -65,8 +65,8 @@ target_sources (seastar-module
net/packet.cc
net/inet_address.cc
net/socket_address.cc
- $<$<NOT:$<BOOL:${Seastar_WITH_OSSL}>>:src/net/tls.cc>
- $<$<BOOL:${Seastar_WITH_OSSL}>:src/net/ossl.cc>
+ $<$<NOT:$<BOOL:${Seastar_WITH_OSSL}>>:net/tls.cc>
+ $<$<BOOL:${Seastar_WITH_OSSL}>:net/ossl.cc>
net/virtio.cc
http/client.cc
http/common.ccWhich seems to be needed for modules.
Signed-off-by: Michael Boquard <michael@redpanda.com>
BenPope
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ups to fix gcc11 compiler errors