Redpanda v22.1.x coroutine #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since std::experimental::coroutine_traits will be removed in LLVM 15,
let's prepare for this change by including <coroutine> when compiling
clang-15 and up.
without this change, when compiling an application using Seastar
coroutine, we could run into following warning:
/home/kefu/dev/redpanda/src/v/net/server.cc:141:19: error: support for std::experimental::coroutine_traits will be removed in LLVM 15; use std::coroutine_traits instead [-Werror,-Wdeprecated-experimental-coroutine]
co_return ss::stop_iteration::yes;
^
/home/kefu/dev/redpanda/build/deps_install/include/seastar/core/std-coroutine.hh:124:7: note: 'coroutine_traits' declared here
class coroutine_traits { };
^
1 error generated.
after this change, the warning is gone.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Message-Id: <20220417023709.2387661-1-tchaikov@gmail.com>
(cherry picked from commit 0a8eea3)
since std::experimental::coroutine_traits will be removed in LLVM 15, but are available in LLVM-14. Update the check to prevent the warning for LLVM-14, as well.. This is a followup to 0a8eea3 Signed-off-by: Ben Pope <ben@redpanda.com> Closes scylladb#1073 (cherry picked from commit 070ab10)
BenPope
force-pushed
the
redpanda-v22.1.x-coroutine
branch
from
58a3912
to
460ca88
Compare
|
This is an alternative fix that doesn't rely on a seastar update, but won't help with open source builds: https://github.com/redpanda-data/vtools/pull/681 |
jcsp
approved these changes
May 24, 2022
BenPope
added a commit
to BenPope/redpanda
that referenced
this pull request
May 24, 2022
Pulls in redpanda-data/seastar#22 Signed-off-by: Ben Pope <ben@redpanda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include fixes for warnings for building with clang 14.
And the change upstream: scylladb#1073
I pulled in the orginal fix so that future merges are easier.
Changes in force-push