Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redpanda v22.1.x coroutine #22

Merged
merged 2 commits into from
May 24, 2022

Commits on May 23, 2022

  1. std-coroutine: include <coroutine> for LLVM-15

    since std::experimental::coroutine_traits will be removed in LLVM 15,
    let's prepare for this change by including <coroutine> when compiling
    clang-15 and up.
    
    without this change, when compiling an application using Seastar
    coroutine, we could run into following warning:
    
    /home/kefu/dev/redpanda/src/v/net/server.cc:141:19: error: support for std::experimental::coroutine_traits will be removed in LLVM 15; use std::coroutine_traits instead [-Werror,-Wdeprecated-experimental-coroutine]
                      co_return ss::stop_iteration::yes;
                      ^
    /home/kefu/dev/redpanda/build/deps_install/include/seastar/core/std-coroutine.hh:124:7: note: 'coroutine_traits' declared here
    class coroutine_traits { };
          ^
    1 error generated.
    
    after this change, the warning is gone.
    
    Signed-off-by: Kefu Chai <tchaikov@gmail.com>
    Message-Id: <20220417023709.2387661-1-tchaikov@gmail.com>
    (cherry picked from commit 0a8eea3)
    tchaikov authored and BenPope committed May 23, 2022
    Configuration menu
    Copy the full SHA
    d69ffc6 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. std-coroutine: include for LLVM-14

    since std::experimental::coroutine_traits will be removed in LLVM 15,
    but are available in LLVM-14.
    
    Update the check to prevent the warning for LLVM-14, as well..
    
    This is a followup to 0a8eea3
    
    Signed-off-by: Ben Pope <ben@redpanda.com>
    
    Closes scylladb#1073
    
    (cherry picked from commit 070ab10)
    BenPope committed May 24, 2022
    Configuration menu
    Copy the full SHA
    460ca88 View commit details
    Browse the repository at this point in the history