Support python 3.12, Simplify some steps. #54
Conversation
It runs the .py and opens up the browser
| # JoyDance | ||
| # JoyDance Python312 |
| - PC/Mac/Linux with bluetooth support. Doesn't work with Chrome OS/Crostini ([#15](../../issues/15)). | ||
| - [Python 3.7+](https://www.python.org) and [pip](https://pip.pypa.io/en/stable/installation/) installed. | ||
| - PC/Mac/Linux with bluetooth support. Doesn't work with Chrome OS/Crostini ([#15](https://github.com/redphx/joydance/issues/15)). | ||
| - [Python 3.11+](https://www.python.org) and [pip](https://pip.pypa.io/en/stable/installation/) installed. |
There was a problem hiding this comment.
Is it possible to retain support for older Python versions so that people who already have this installed can continue to use it without upgrading Python?
| 1. Download [the latest version](https://github.com/redphx/joydance/releases/latest/) and extract it into a folder. | ||
| 2. Open that folder in Terminal/Command Prompt, then run this command: | ||
| ``` | ||
| pip3 install -r requirements.txt | ||
| ``` | ||
| 1. Download [the latest version](https://github.com/lorenzwan/joydance-python312/releases/latest/) and extract it into a folder. | ||
| 2. Run `install.bat` |
There was a problem hiding this comment.
You should revert the link and ensure the old command is mentioned so that non-Windows operating systems still work.
That said, how useful is this actually? It runs one command.
| 3. Run this command: | ||
| ``` | ||
| python3 dance.py | ||
| ``` | ||
| or | ||
| ``` | ||
| python dance.py | ||
| ``` | ||
| 3. Run `dance.bat` |
There was a problem hiding this comment.
Once again, ensure the old command is mentioned for macOS and Linux support.
There was a problem hiding this comment.
This is a single line. How useful is it actually?
Also, a new line would be good here.
There was a problem hiding this comment.
Is it worth it for two lines? To be fair, I did personally create a .ps1 script for this exact same reason...
It's a best practice to add new lines to the end of files. Apparently GitHub Mobile crashes when I review a file that doesn't end in a newline...
No description provided.