Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of prompt #74

Closed
chen-robert opened this issue Feb 29, 2020 · 0 comments · Fixed by #123
Closed

Fix use of prompt #74

chen-robert opened this issue Feb 29, 2020 · 0 comments · Fixed by #123
Assignees
@ethanwu10
Labels
bug Something isn't working

Comments

@chen-robert
Copy link
Member

As mentioned in #73, we should remove the use of prompt which blocks the event loop.

The best solution would probably a custom popup box.
@chen-robert chen-robert added the bug Something isn't working label Feb 29, 2020
@ethanwu10 ethanwu10 self-assigned this Mar 24, 2020
ethanwu10 added a commit that referenced this issue Mar 24, 2020
@ethanwu10
feat(client): add modal for confirming account deletion
60bd155 
Add modal component using Cirrus's modals (with manual animations, since
Cirrus relies on using the URI hash to show/hide modals), and use it to
implement confirmation for deleting accounts instead of `prompt()`

Closes #74
@ethanwu10 ethanwu10 mentioned this issue Mar 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanwu10 ethanwu10

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add modal for confirming account deletion redpwn/rctf
2 participants
@ethanwu10 @chen-robert