Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update profile frontend card #73

Merged
merged 4 commits into from
Feb 29, 2020
Merged

Update profile frontend card #73

merged 4 commits into from
Feb 29, 2020

Conversation

chen-robert
Copy link
Member

Added a card for the frontend delete and update profile operations.

image

Copy link
Member

@jimmyl02 jimmyl02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, might want to consider a cooldown for name changes.

Copy link
Member

@ginkoid ginkoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

handleDelete = e => {
const resp = prompt('Please type your team name to confirm: ' + this.state.name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prompt blocks all execution the main thread, we should not be using it.

@chen-robert chen-robert mentioned this pull request Feb 29, 2020
@chen-robert chen-robert merged commit 89c7be9 into master Feb 29, 2020
@chen-robert chen-robert deleted the feature/delete-frontend branch February 29, 2020 03:18
nick-ls pushed a commit to nick-ls/rctf that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants