Skip to content

Commit

Permalink
Merge pull request #22 from justmarkup/master
Browse files Browse the repository at this point in the history
Mark summary attribute on table element as deprecated
  • Loading branch information
redroot committed Sep 11, 2013
2 parents 346c2d1 + 277b65b commit c1e0399
Showing 1 changed file with 7 additions and 24 deletions.
31 changes: 7 additions & 24 deletions holmes.css
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,6 @@
.holmes-debug [class=""],
.holmes-debug [id=""],

.holmes-debug table:not([summary]),
.holmes-debug table[summary=""]{
outline: 2px solid red;
}
/*
Warnings here, for inline styles and event calls,
ideally they should be external (CSS) and JS applied by JS scripts,
Expand Down Expand Up @@ -158,7 +154,8 @@ body.holmes-debug[leftmargin] {
.holmes-debug *[bordercolor],
.holmes-debug *[bordercolordark],
.holmes-debug *[bordercolorlight],
.holmes-debug table[frame] {
.holmes-debug table[frame],
.holmes-debug table[summary] {
border: 2px solid #a9a9a9;
}

Expand Down Expand Up @@ -251,20 +248,6 @@ body.holmes-debug[leftmargin] {
.holmes-debug [class=""]:hover::after,
.holmes-debug [id=""]:hover::after,

.holmes-debug table:not([summary]):hover::after,
.holmes-debug table[summary=""]:hover::after {
border-radius: 0.5em;
display:block;
padding: 1em;
margin: 1em;
background: red;
position: fixed;
color: #000;
left: 0px;
top: 0px;
z-index: 9999;
text-decoration: none;
}

/* ===================== */
/* = Deprecated Styles = */
Expand All @@ -288,6 +271,7 @@ body.holmes-debug[leftmargin] {
.holmes-debug *[bordercolorlight]:hover::after,

.holmes-debug table[frame]:hover::after,
.holmes-debug table[summary]:hover::after,
.holmes-debug *[align]:hover::after,
.holmes-debug *[valign]:hover::after,
.holmes-debug *[bgcolor]:hover::after,
Expand Down Expand Up @@ -408,11 +392,6 @@ body.holmes-debug[leftmargin]:hover::after {
content:'Blank id attribute';
}

.holmes-debug table:not([summary]):hover::after,
.holmes-debug table[summary=""]:hover::after {
content:'Missing summary attribute';
}

.holmes-debug [style]:hover::after {
content: 'Element has inline styles';
}
Expand Down Expand Up @@ -467,6 +446,10 @@ body.holmes-debug[leftmargin]:hover::after {
content:'Deprecated or Non-W3C table attribute frame';
}

.holmes-debug table[summary]:hover::after {
content:'Deprecated or Non-W3C table attribute summary';
}

.holmes-debug *[align]:hover::after,
.holmes-debug *[valign]:hover::after {
content:'Deprecated or Non-W3C attribute *align';
Expand Down

0 comments on commit c1e0399

Please sign in to comment.