Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Frappé error code for NATS communication issues #1

Closed
wants to merge 2 commits into from

Conversation

cv711
Copy link

@cv711 cv711 commented Jul 9, 2019

One more beverage for the list: Frappé

Copy link
Contributor

@deepakprabhakara deepakprabhakara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change Frappé -> Frappe.
Why regenerate the files again? Let's roll it back to what it was.

@deepakprabhakara
Copy link
Contributor

@cv711 Also document the new coffee code here - https://github.com/redsift/guide/wiki

@cv711
Copy link
Author

cv711 commented Jul 10, 2019

  • I saw Bombón in the list, that's why I went with the accent, will change it.
  • If I don't run go generate how are files like internalstate_jsonenums.go going to be updated? The rest of the changes are mainly variables that were renamed and changes in the comments probably due to a newer version of the library.

@deepakprabhakara
Copy link
Contributor

You only need changes from internalstate_string.go. What are the side effects of the changes to the errors (with the additonal wrapping from the new lib)? Are those fully tested on all the repos that use go-errs?

@cv711
Copy link
Author

cv711 commented Jul 15, 2019

  • The lib is backwards compatible and the only side effect is that some errors will have a bit more information to help with identifying their underlying cause. As you can see here the new internal type errWrapped will check if there are any additional information in the context to enhance the error or just print the error.
  • Testing with prism there are no issues with these changes and for the rest of the repos they either use a Gopkg.lock or a go.sum to lock dependencies so it can be tested before their next release.

@deepakprabhakara deepakprabhakara deleted the feat/frappe-code branch September 15, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants