Enable XEP-0198 support #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support was added in Smack 4.1.0
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for stream management was added in Smack 4.1.0, so toggling the pref is enough. We don't need to check the server capabilities ourselves, quoting the Smack documentation:
I also removed the unnecessary cast from
AbstractXMPPConnectiontoXMPPTCPConnectionbecause we actually do have aXMPPTCPConnectionhere and I see no reason to cast here. Feel free to prove me wrong.In my second commit, I have sorted the list of supported XEPs which is not really in the scope of this PR. I usually don't like sidetracked changes like this, but I think it really improves readability... Feel free to complain, I'll happily remove this commit if needed.
Merging this would resolve #67.