Better missing security reporting #43
Conversation
…y to use self.ofx.security_list to report more useful information. At least in Fidelity ofx files both the symbol and security name are present, so in most cases the required additions to fund_info.py are already in the file.
|
Example of the change, old: New: |
|
Nice upgrade, thanks for the PR! Happy to merge it, would you mind addressing the linting error? |
|
Sorry, I wasn't familiar with the f string notation. Should have looked it up |
2. Key the extracted securities dict by CUSIP (not symbol) which matches what is found
in the transaction entries (not for bonds symbol generally matches CUSIP)
3. Values of dict are now a tuple of (symbol, cusip, name) which for stocks should be all
that is needed for fund_info.py
|
After thinking about this some more I realized it was probably only correct in the case of a bond where CUSIP matches symbol in the OFX (which was the example I ran into today). The OFX securities list does include CUSIP, symbol and name, so I changed this to return all three in a tuple that should match what is needed for |
|
Linter failed again 🙂. Just a minor thing: the f needs to be removed. Sorry this is annoying. I think GitHub will let you run the linter yourself on future PRs. |
|
Ugh, unbelievable...same issue but one line away. Sorry. Unless I'm looking in the wrong place I think it would let me run it had I merged something before, but it says "First-time contributors need a maintainer to approve running workflows" |
|
Heh, all good now, and further PRs will let you run the linter. Thanks! |
* if get_ticker_info_from_id finds an id not present in fund_info.py try to use self.ofx.security_list
to report more useful information. At least in Fidelity ofx files both the symbol and security name
are present, so in most cases the required additions to fund_info.py are already in the file.
* Slightly better reportings...print a summary line before list of securities
* remove unused f string
* 1. Comments to explain what is going on
2. Key the extracted securities dict by CUSIP (not symbol) which matches what is found
in the transaction entries (not for bonds symbol generally matches CUSIP)
3. Values of dict are now a tuple of (symbol, cusip, name) which for stocks should be all
that is needed for fund_info.py
* Remove another unnecessary f string
Co-authored-by: Ware Adams <ware@rwa.washdcmail-intranet.lan>
If
get_ticker_info_from_idfinds a missingsecurity_idtry to use asecurity_listin the ofx itself to print out useful information.Fidelity ofx files appear to have a full security list embedded, and in most (all?) cases this is all that is needed to update
fund_info.py. All that this does is print out a list of the symbols (as is already done) and thenameprovided in the ofx.If
security_listis missing from the ofx the behavior should be no worse than today...print a list of missing symbols.