Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better missing security reporting #43

Merged
merged 5 commits into from
Jan 16, 2023

Commits on Jan 14, 2023

  1. if get_ticker_info_from_id finds an id not present in fund_info.py tr…

    …y to use self.ofx.security_list
    
    to report more useful information.  At least in Fidelity ofx files both the symbol and security name
    are present, so in most cases the required additions to fund_info.py are already in the file.
    Ware Adams committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    9a7d480 View commit details
    Browse the repository at this point in the history
  2. Slightly better reportings...print a summary line before list of secu…

    …rities
    Ware Adams committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    93ba75e View commit details
    Browse the repository at this point in the history
  3. remove unused f string

    thehill committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    71d0fd1 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2023

  1. 1. Comments to explain what is going on

    2. Key the extracted securities dict by CUSIP (not symbol) which matches what is found
         in the transaction entries (not for bonds symbol generally matches CUSIP)
    3. Values of dict are now a tuple of (symbol, cusip, name) which for stocks should be all
         that is needed for fund_info.py
    thehill committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    d97d268 View commit details
    Browse the repository at this point in the history
  2. Remove another unnecessary f string

    thehill committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    38cc16f View commit details
    Browse the repository at this point in the history