-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add header with API version #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rengehn , thanks for your contribution! See my comment about the implementation.
Don't forget, please, to add a record into CHANGELOG.md and a test into api_tests/http_test.py
.
P.S. And fill please the PR template, so that we could keep the context. Thanks!
@renghen , the code looks good for me. I resolved conflicts with the |
Just figured out that I need it urgently. I've taken it with the broken CI but I'll fix it in the |
I did a cargo fmt before any push, I need to check what goes wrong on that one |
I got it, I should use |
Closes #249
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
See #249
What is the new behavior?
The 'x-reduct-api' header is added with the API version for each response
Does this PR introduce a breaking change?
No
Other information: