-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immutable FieldArrays broken with Immutable 4.0.0-rc.5+ #3489
Comments
Try |
I'm also experiencing this issue when calling I'm running redux-form@7.1.0 & immutable@4.0.0-rc.7. |
…nts issue redux-form#3489 locking version of immutable
@erikras I still see the error |
|
I tried replicating the old mergeDeep behavior here: TikiTDO@fd7d616 It seems to work well enough for my use case, but I'm not entirely sure what problem is being solved here, so I can't speak to other scenarios. |
@erikras If you get a second could you comment on the above fix? This issue is hitting us pretty hard. |
All my form with FieldArrays is broken after updating immutable-js version to 4.0.0-rc.7, my redux-form version is 7.2.0 |
Any news? We are very much looking forward to solving the problem |
No news, sorry. |
@gustavohenke do you plan to solve this issue? |
@Defenderbass I'm still waiting for someone to comment on my PR, but we've been using it for our project for a couple of weeks now with no issues. |
@TikiTDO I tried to use your option, but the fields began to disappear from the array. That is, the merge was not done correctly. I had to come up with my own version |
@Defenderbass I tried to reproduce what the functionality of the original mergeDeepWith, but didn't spend too much time on it. I can go fix mine, but if you believe yours works then I'm good with that too. If you have a branch I can try let me know and I'll see if it solves my problem too. |
@Defenderbass Sounds good. I'm in an all day meeting, but I'll give it a try this evening. |
Published fix in |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Are you submitting a bug report or a feature request?
Bug
What is the current behavior?
Using FieldArrays results in
Uncaught TypeError: original.mergeDeepWith is not a function
What is the expected behavior?
Expected to not do that.
Sandbox Link
What's your environment?
redux-form@7.0.4
immutable@4.0.0-rc.7
node@7.10.1
Other information
The method
mergeDeepWith
has been removed from the List API since 4.0.0-rc.5 so now any interaction with FieldArrays causes this exception to show up.The text was updated successfully, but these errors were encountered: