Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends PR #3460, also locks immutable version #3496

Merged
merged 2 commits into from
Oct 9, 2017

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Oct 9, 2017

The main purpose of this PR is to add the same logic that PR #3460 (which was merged) added to onChange also to onBlur and onFocus.

I've also edited a dev-dependecy line of package.json:

-"immutable": "^4.0.0-rc.3",
+"immutable": "4.0.0-rc.3",

This was necessary to prevent the test suite to fail miserably with 21 errors (all of them are immutable-related). This isn't a solution to #3493, but it's needed to mark the fact that versions 4.0.0-rc.>3 of immutable aren't supported as of now. I hope this doesn't add to much noise to the PR @erikras.

@codecov-io
Copy link

codecov-io commented Oct 9, 2017

Codecov Report

Merging #3496 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3496   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          69      69           
  Lines        1533    1537    +4     
======================================
+ Hits         1533    1537    +4
Impacted Files Coverage Δ
src/ConnectedField.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19bd7cb...466a273. Read the comment docs.

@erikras erikras merged commit 524d1cd into redux-form:master Oct 9, 2017
@jkomyno
Copy link
Contributor Author

jkomyno commented Oct 9, 2017

Thanks for merging!

@lock
Copy link

lock bot commented Jun 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants