Add more tests for validateIfNeeded & warnIfNeeded #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Copied validateIfNeeded tests for warnIfNeeded * Added a test to check if values and props are correctly passed to validate & warn
|
Great! 👍 |
selvagsz
added a commit
to selvagsz/redux-form
that referenced
this pull request
Feb 6, 2017
* redux-form/master: (61 commits) Exported getFormNames (redux-form#2519) v6.5.0 Do not set FieldArray as touched on submit, as it causes its entry in storeState.fields to become an object instead of an array. The ARRAY_* reducers expects the fields entry to be an array. Fixes redux-form#2014. (redux-form#2473) Chore/switch shallowequal to lodash isequalwith (redux-form#2506) Keep track of registration count in registeredFields (redux-form#2470) fix: when the Field type is "file", value can not be updated (redux-form#2452) Remove undocumented name, validate and warn from FieldArray props. (redux-form#2467) Clarify what to do when StackOverflow questions get no answers (redux-form#2497) Excluded tests from code climate Enable Code Climate (redux-form#2486) Update ConnectedFields cached handlers when names prop changes. Fixes bug introduced by redux-form#2161. (redux-form#2474) Breaking change: Change Fields names instance API to return FormSection prefixed names, to be consistent with Field and FieldArray. (redux-form#2464) Add initial value selector (redux-form#2460) Add more tests for validateIfNeeded & warnIfNeeded (redux-form#2450) Provide validation functions with access to form props (redux-form#2431) feat(initialize): add keepSubmitSucceeded option (redux-form#2426) Synced Immutable and plain exports (+ tests) (redux-form#2425) Choose getIn based off Iterable.isIterable() (redux-form#2423) Fixed redux-form#2444 unexpected value updates when radio lose focus (redux-form#2445) Beerpay badge ...
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #2431.
warnIfNeeded()tests based onvalidateIfNeeded()validate&warnI'm not sure my method for checking props is the most elegant (spying on the props passed to
shouldValidateand comparing with the argument ofvalidatewithObject.keys()) but I couldn't find a state where the props had the exact same values as well.Let me know if I missed anything, thanks!