New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial value selector #2460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #2460 diff @@
=====================================
Files 65 66 +1
Lines 1322 1325 +3
Methods 0 0
Messages 0 0
Branches 0 0
=====================================
+ Hits 1322 1325 +3
Misses 0 0
Partials 0 0
|
gustavohenke
approved these changes
Jan 16, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Released as |
selvagsz
added a commit
to selvagsz/redux-form
that referenced
this pull request
Feb 6, 2017
* redux-form/master: (61 commits) Exported getFormNames (redux-form#2519) v6.5.0 Do not set FieldArray as touched on submit, as it causes its entry in storeState.fields to become an object instead of an array. The ARRAY_* reducers expects the fields entry to be an array. Fixes redux-form#2014. (redux-form#2473) Chore/switch shallowequal to lodash isequalwith (redux-form#2506) Keep track of registration count in registeredFields (redux-form#2470) fix: when the Field type is "file", value can not be updated (redux-form#2452) Remove undocumented name, validate and warn from FieldArray props. (redux-form#2467) Clarify what to do when StackOverflow questions get no answers (redux-form#2497) Excluded tests from code climate Enable Code Climate (redux-form#2486) Update ConnectedFields cached handlers when names prop changes. Fixes bug introduced by redux-form#2161. (redux-form#2474) Breaking change: Change Fields names instance API to return FormSection prefixed names, to be consistent with Field and FieldArray. (redux-form#2464) Add initial value selector (redux-form#2460) Add more tests for validateIfNeeded & warnIfNeeded (redux-form#2450) Provide validation functions with access to form props (redux-form#2431) feat(initialize): add keepSubmitSucceeded option (redux-form#2426) Synced Immutable and plain exports (+ tests) (redux-form#2425) Choose getIn based off Iterable.isIterable() (redux-form#2423) Fixed redux-form#2444 unexpected value updates when radio lose focus (redux-form#2445) Beerpay badge ...
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemed like an important missing selector. While a user of redux-form will usually have access to the initial values they passed in one way or another, exposing a selector for them can make it easier to hook into redux-form with epic, thunks, and sagas (invoking the selector on getState()) and keep business logic out of the component.
I'd be happy to describe a specific use case if desired.