Fields re-render every time due to regression introduced with flow typings. #3758
Conversation
… when determining if a Field should re-render
| const propsEqual = isEqualWith(instance.props, nextProps, customizer) | ||
| const stateEqual = isEqualWith(instance.state, nextState, customizer) | ||
|
|
||
| return !propsEqual || !stateEqual |
There was a problem hiding this comment.
I like how readable this function is now 💯
|
@erikras is there any way to retry travis-ci? I dont really understand why it failed, since there seems to be no logs :) |
|
@gustavohenke I attempted for a while to write a test for it. But for some reason the actual component specified to the The test I wrote to check if is basically equal to https://github.com/erikras/redux-form/blob/878176b0e960d58a3277a2bd83703e8da3e82eb6/src/__tests__/Field.spec.js#L874 however I could not make the |
…ed multiple times if neither state nor props have changed
|
@gustavohenke I figured out a way :) Had to make a sub-class of the Field-class to check it though, so the test is kind of hacky. If you know of any other way of testing this please let me know :) |
Codecov Report
@@ Coverage Diff @@
## master #3758 +/- ##
======================================
Coverage 100% 100%
======================================
Files 70 70
Lines 1587 1589 +2
======================================
+ Hits 1587 1589 +2
Continue to review full report at Codecov.
|
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR fixes a regression introduced in #3138 where the
shouldComponentUpdatemethod ofcreateField.jsno longer sentnextStateas an argument toshallowComparewhen checking if a component should update. This regression effectively made every field re-render every time since the default state of a react component isnulland an unspecified argument isundefined, makingshallowComparedo anull === undefinedcheck to determine if the component should update.