Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields re-render every time due to regression introduced with flow typings. #3758

Merged
merged 3 commits into from
Jan 18, 2018
Merged

Fields re-render every time due to regression introduced with flow typings. #3758

merged 3 commits into from
Jan 18, 2018

Commits on Jan 16, 2018

  1. Fixes regression introduced in #3138 that no longer checked nextState… 

    … when determining if a Field should re-render
    @dagstuan
    dagstuan committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    84be24d View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2018

  1. Adds test to make sure the render()-function of the field is not call… 

    …ed multiple times if neither state nor props have changed
    @dagstuan
    dagstuan committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    b983f3d View commit details
    Browse the repository at this point in the history

  2. nextState in shouldComponentUpdate() must be optional

    @dagstuan
    dagstuan committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    ee53455 View commit details
    Browse the repository at this point in the history