Maintain static functions

[erikras]

Could connect() check its wrapped component for static functions and add them to the returned component? For things like fetchData() and onEnter(). Seems like it would be pretty easy to go through the keys and check if typeof WrappedComponent[key] === 'function'.

Just a thought.

[gaearon]

I wouldn't do that. It's only going to make things worse IMO: acdlite/flummox#173 (comment)

[erikras]

Good call. I briefly looked into implementing it and the code disgusted me.

[gaearon]

I'm happy to reconsider it using https://github.com/mridgway/hoist-non-react-statics since we don't have to maintain it. Wanna make a PR?

[erikras]

I was going to complain about the lack of docs for that library, but then I saw how utterly trivial the code is. Also, I can't remember the time I last used the word "hoist"; such a good word.

Will add the PR to the todo list.

[erikras]

I just, by chance, ran into a problem in my app where I need this functionality. Any chance of a release soon?

[gaearon]

Give me a few days, vacation :-)

[esamattis]

If in hurry you can do it in userland:

MyComponentConnected = hoistNonReactStatics(connect(mapState)(MyComponent), MyComponent);

It should be future compatible.

[erikras]

You and your pink crocs enjoy your vacation. No hurry. 🐚 🌊 ☀️

For now I've just done MyComponent.WrappedComponent.onEnter to get to my onEnter function.

[gaearon]

Out in 3.1.0.

[gaearon]

Lol. I knew this is going to come back and bite me in the arse.
#163 (comment)