Hoist non-static properties on withTheme HOC #712
Conversation
Fix #596 See for reference: - reduxjs/react-redux#53 - reduxjs/react-redux#276
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
@philpl Please don't do that (close another person PR and make it your own).
Instead, just request changes to the original contributor.
|
|
||
| state: { theme?: ?Object } = {}; | ||
| unsubscribe: () => void; | ||
| class WithTheme extends React.Component { |
There was a problem hiding this comment.
Is it possible to do class WithTheme extends Component? Would that mean statics are available by simple prototype inheritance?
There was a problem hiding this comment.
That's not a good idea, since we'd be overriding some original logic. I'd stick to the HOC-pattern 😉
|
@brunolemos I understand you're upset and I apologise for stepping on your toes. Please do understand however that I've thought about this and opened a fresh PR since it's going to be merged against v2 and now intersects/conflicts with #710. I'm currently trying to move quickly towards the v2 release, and I thought it's safe to move your changes over to a new branch. I'll add an attribution with your name to the changelog, and I hope this doesn't scare you off from contributing to SC in the future. Sorry again! 😅 |
|
@philpl I was just finishing to update this PR with the original commit plus yours, but nevermind, you merged it. Not good, philpl. |
|
@brunolemos Hey, man. I'm sorry I went ahead, but I can't read your mind and guess what you're up to. Yes, this is unfortunate, but at the end of the day it's just code, so please don't be passive aggressive about this, because that doesn't help either of us, since it's not constructive. I'm happy to buy you a beer and apologise in person, if we end up in the same city one day. We don't have to escalate this further and turn this into something bigger than it is. Sorry again, mate |
|
@philpl It's constructive in the way that my intention is that you don't do that again with other contributor or a project member like me. Besides that, no problem, keep moving fast. |
Fix #596
See for reference:
hoist-non-react-statics? reduxjs/react-redux#276