-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with isValidElementType invariant check crashing on valid t… #1122
Conversation
Deploy preview for react-redux-docs ready! Built with commit 8d3af26 |
Can you run this through Prettier? And can you add a test? |
…ype with circular structure
1fe203a
to
8d3af26
Compare
@@ -27,4 +27,7 @@ if (version.toLowerCase() === 'all') { | |||
} | |||
} | |||
|
|||
npmRun.execSync(`jest -c '${JSON.stringify(jestConfig)}'`, { stdio: 'inherit' }) | |||
npmRun.execSync( | |||
`jest -c '${JSON.stringify(jestConfig)}' ${process.argv.slice(2).join(' ')}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has actually allowed me to use --watch
(which is still not ideal because we have to edit copy of tests rather than real test files to benefit from that, but better this now than nothing)
@@ -42,12 +42,12 @@ npm run test | |||
|
|||
To run in explicit React versions (the number is the version, so `test:16.3` will run in React version `16.3`): | |||
``` | |||
REACT=16.4 npm run test:ci | |||
REACT=16.4 npm run test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no test:ci
script
Done & done. |
Thanks for this and the other updates! |
…ype with circular structure (reduxjs#1122)
…ype with circular structure
Repro - https://codesandbox.io/s/jnmoxr5mk3
Emotion is attaching created component to the returned styled component (creating a circular structure) to easily "flatten" subsequent calls wrapping that component, as in: