Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some minor hooks updates #1294

Merged
merged 3 commits into from May 25, 2019
Merged

some minor hooks updates #1294

merged 3 commits into from May 25, 2019

Conversation

@MrWolfZ
Copy link
Contributor

MrWolfZ commented May 25, 2019

  • fix wrong inline documentation for useSelector hook
  • add test to get test coverage for useSelector to 100%
  • add test to verify that docs suggestion of putting a connected component above the hooks component allows dealing with stale props
@netlify

This comment has been minimized.

Copy link

netlify bot commented May 25, 2019

Deploy preview for react-redux-docs ready!

Built with commit 7626018

https://deploy-preview-1294--react-redux-docs.netlify.com

…ent above the hooks component allows dealing with stale props
@timdorr

This comment has been minimized.

Copy link
Member

timdorr commented May 25, 2019

Also LGTM.

@timdorr timdorr merged commit 442112a into reduxjs:v7-hooks-alpha May 25, 2019
7 checks passed
7 checks passed
Header rules - react-redux-docs No header rules processed
Details
Pages changed - react-redux-docs All files already uploaded
Details
Mixed content - react-redux-docs No mixed content detected
Details
Redirect rules - react-redux-docs 5 redirect rules processed
Details
codecov/project 98.31% remains the same compared to 0e41eae
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/react-redux-docs/deploy-preview Deploy preview ready!
Details
timdorr added a commit that referenced this pull request May 30, 2019
* fix wrong inline documentation for useSelectors hook

* add test to get test coverage for useSelector to 100%

* add test to verify that docs suggestion of putting a connected component above the hooks component allows dealing with stale props
timdorr added a commit that referenced this pull request Jun 11, 2019
* fix wrong inline documentation for useSelectors hook

* add test to get test coverage for useSelector to 100%

* add test to verify that docs suggestion of putting a connected component above the hooks component allows dealing with stale props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.