Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem introduced by previous refactor in shallowEqual #624

Closed
wants to merge 1 commit into from
Closed

Conversation

jddxf
Copy link

@jddxf jddxf commented Feb 17, 2017

Previous refactor shallowEqual has introduced an issue as follow

function A() {}
A.prototype.a = 1
const a = new A()
const b = { a: 2 }
shallowEqual(a, b) // returns true, expects false

@timdorr
Copy link
Member

timdorr commented Feb 17, 2017

This will be handled by #591. Thanks!

@timdorr timdorr closed this Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants