Remove subkey #945
Merged
Remove subkey #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdorr
approved these changes
May 5, 2018
|
Imma just merge these in. Thanks! |
josepot
pushed a commit
to josepot/react-redux-lean
that referenced
this pull request
Sep 21, 2018
* Add test for custom store key to connect * Remove subkey
webguru7
pushed a commit
to webguru7/react-redux
that referenced
this pull request
Dec 8, 2022
* Add test for custom store key to connect * Remove subkey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removed
subKeyoption fromcreateProvider.The
subKeyisn't really useful becauseconnectcomponents doesn't know the custom subscription key.And according to discussion #944 , removing the
subKeymakes things simpler.Provider