Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement toggle #12

Merged
merged 6 commits into from Jul 19, 2015
Merged

Implement toggle #12

merged 6 commits into from Jul 19, 2015

Conversation

pburtchaell
Copy link

  • Adds monitorState object to track the state of the monitor, e.g., if it is visible or not.
  • Adds show() action creator to show monitor
  • Adds hide() action creator to hide monitor
  • Moves the padding from the monitor container to the monitor itself; having the padding on the container prevented the monitor from being fully hidden.
  • Adds some help text at the top of the monitor to explain how to hide the monitor.

gaearon added a commit that referenced this pull request Jul 19, 2015
@gaearon gaearon merged commit 1d5791e into reduxjs:master Jul 19, 2015
@gaearon
Copy link
Contributor

gaearon commented Jul 19, 2015

Thank you!!

@gaearon
Copy link
Contributor

gaearon commented Jul 19, 2015

I think we can probably generalize show and hide as something like setUIState and this.props.uiState so different monitors can use devTools.js but store different things there.

@pburtchaell
Copy link
Author

Yeah, that would be a good idea. Perhaps something to mention on #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants