Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier #262

Merged
merged 5 commits into from
Aug 29, 2019
Merged

Add Prettier #262

merged 5 commits into from
Aug 29, 2019

Conversation

jednano
Copy link
Contributor

@jednano jednano commented Aug 29, 2019

Uses the following libraries to make this repo more contributor-friendly:

Automatic npm/GitHub release 馃摝 猬嗭笍

This PR (if merged into master) and any future PRs merged directly into master will trigger an npm & GitHub release + changelog. This is done via @jedmao/semantic-release-npm-github-config, as mentioned in Semantic Release Community Configurations.

This was done in an effort to make maintenance and releases less of a burden to maintainers.

馃榾 鉂わ笍

Important! 馃毃

Before merging this PR (if you so decide), ensure that the following secret environment variables are set in your Travis-CI settings:

@markerikson
Copy link
Contributor

markerikson commented Aug 29, 2019

I'll be honest and say I really am not fond of the "conventional commit" format. In addition, I don't think we want to do a release every time there's a merge to master.

I would be potentially interested in more of a "push-button" automation for our Redux package releases in general, but this seems like more than I'd like added atm.

Is this something of a drive-by PR, or was this discussed with @timdorr at some point?

@jednano
Copy link
Contributor Author

jednano commented Aug 29, 2019

Drive-by 馃殫 馃槅

I noticed a conventional commit in the commit history is all. Happy to modify the PR as needed.

@jednano
Copy link
Contributor Author

jednano commented Aug 29, 2019

Not sure how to automate the package versions w/o conventional commits though.

@jednano
Copy link
Contributor Author

jednano commented Aug 29, 2019

Perhaps something like this? https://github.com/sindresorhus/np

@timdorr
Copy link
Member

timdorr commented Aug 29, 2019

Yeah, can we break this out into individual PRs? Adding Prettier is definitely worth its own commit.

@jednano
Copy link
Contributor Author

jednano commented Aug 29, 2019

Just removed anything related to semantic release or conventional commits.

@markerikson
Copy link
Contributor

And yes, I myself use np for doing actual publishing.

@jednano jednano changed the title Make repo more friendly to contributors Add Prettier Aug 29, 2019
@timdorr
Copy link
Member

timdorr commented Aug 29, 2019

I prefer the handcrafted, vintage, artisanal npm publish approach myself :neckbeard:

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@timdorr
Copy link
Member

timdorr commented Aug 29, 2019

Thanks for the quick turnaround! The inconsistent semis and quotes was bugging me 馃槃

@timdorr timdorr merged commit 3f56c2f into reduxjs:master Aug 29, 2019
@jednano jednano deleted the semantic-release branch August 29, 2019 18:40
@jednano
Copy link
Contributor Author

jednano commented Aug 30, 2019

And yes, I myself use np for doing actual publishing.

Speaking of publishing, it's been a year since redux-thunk's last release. When can I expect to get my hands on a published version of #260? I really need it to fix a TS hole in Redux Starter Kit.

@timdorr
Copy link
Member

timdorr commented Aug 30, 2019

I can poke at it soon. It may be Monday, as I'm occupied by Dragon Con this weekend.

@jednano
Copy link
Contributor Author

jednano commented Aug 30, 2019

Thanks and let me know if you need any help with anything TypeScript related. I just saw reduxjs/redux#3536.

@timdorr
Copy link
Member

timdorr commented Aug 30, 2019

Actually, check out reduxjs/redux#3500 for the full details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants