Skip to content

Commit

Permalink
Merge pull request #3672 from reduxjs/feature/3516-fix-dist-types
Browse files Browse the repository at this point in the history
  • Loading branch information
markerikson committed Aug 26, 2023
2 parents 32e9081 + 25b84d0 commit 1ee08e0
Show file tree
Hide file tree
Showing 18 changed files with 126 additions and 2,473 deletions.
39 changes: 24 additions & 15 deletions .github/workflows/tests.yml
Expand Up @@ -149,16 +149,7 @@ jobs:
fail-fast: false
matrix:
node: ['16.x']
example:
[
'cra4',
'cra5',
'next',
'vite',
'node-standard',
'node-esm',
'are-the-types-wrong',
]
example: ['cra4', 'cra5', 'next', 'vite', 'node-standard', 'node-esm']
defaults:
run:
working-directory: ./examples/publish-ci/${{ matrix.example }}
Expand Down Expand Up @@ -197,9 +188,27 @@ jobs:

- name: Run test step
run: yarn test
if: matrix.example != 'are-the-types-wrong'

- name: Run test step (attw)
# Ignore "FalseCJS" errors in the `attw` job
run: yarn test -n FalseCJS
if: matrix.example == 'are-the-types-wrong'
are-the-types-wrong:
name: Check package config with are-the-types-wrong

needs: [build]
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node: ['16.x']
steps:
- name: Checkout repo
uses: actions/checkout@v3

- uses: actions/download-artifact@v2
with:
name: package
path: packages/toolkit

- name: show folder
run: ls -l .

- name: Run are-the-types-wrong
run: npx @arethetypeswrong/cli ./package.tgz --format table --ignore-rules false-cjs
35 changes: 0 additions & 35 deletions examples/publish-ci/are-the-types-wrong/.gitignore

This file was deleted.

This file was deleted.

0 comments on commit 1ee08e0

Please sign in to comment.