Fix multiple TS build and packaging issues #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 25b84d0:
|
markerikson
force-pushed
the
feature/3516-fix-dist-types
branch
from
dbd5d21
to
82cfc2a
Compare
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
markerikson
force-pushed
the
feature/3516-fix-dist-types
branch
3 times, most recently
from
33864fc
to
7a292cb
Compare
markerikson
force-pushed
the
feature/3516-fix-dist-types
branch
from
7a292cb
to
869943e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
tsupto 7.2.0, to pick up the "multiple declarations" feature from Ensure matching declaration file exists for each output bundle format egoist/tsup#934/dist/in type imports, by re-exporting needed typesUpdates ourtsupconfig to generate typedefs for ESM and CJS formats, and switches to using those typedef files instead of building individual files withtscUpdates all package exports to list separate JS + DTS files for ESM and CJS for each entry pointare-the-types-wrongCLI package for checking output, instead of the homegrown CLI I'd thrown togetherSomewhat surprisingly, this actually appears to fix all outstanding ATTW issues locally:Update
Yeah, I gave up on pre-bundling our TS typedefs for RTK. I'm also going to punt completely on fixing the "FalseCJS" warning from
attw.We have some really complicated uses of interface merging in RTK Query, and bundling the typedefs was completely breaking that, as we no longer had paths like
"@reduxjs/toolkit/dist/query/apiTypes"on disk. Plus, uses ofdeclare module "../../endpointDefinitions"seemed busted too.I tried copy-pasting all the individual
.d.tsfiles to.d.mts/cts, but that seemed to result in a lot of internal resolution errors fromattw.I did generally replace all of the remaining uses of
/dist/, and exported a few more types publicly.