New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve error handling of fetchBaseQuery #1250
Conversation
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: 4fd483c 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/60e20668f71dfa00083151f6 😎 Browse the preview: https://deploy-preview-1250--redux-starter-kit-docs.netlify.app |
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4e137a6:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great 💪 . We'll just need to update docs to reflect these changes, but that's not a blocker for getting this in.
Fixes #1234
It will still cause an error, but a graceful one without information to be lost. This is probably the best way to tackle that.
Also I added handling for "fetch" failing, e.g. due to connection loss.