-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: point sourceMappingURL to correct sourcemaps in build artifacts #1459
Conversation
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: f09c978 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6131e46b0835a90007f7ebe2 😎 Browse the preview: https://deploy-preview-1459--redux-starter-kit-docs.netlify.app |
I also solved this over in |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f09c978:
|
ohh yes, totally missed the minified bundles 🤦 |
Hm. Good question. I'd say add the other changes over here, in that case we have the option of another patch release if it should come to that. |
@phryneas was away for a bit, thanks for pulling those changes here 🙇 just a heads up, a conflict got merged with this, two different redux-toolkit/packages/toolkit/scripts/build.ts Lines 200 to 209 in c020f97
|
Great observation, thanks! I fixed it directly on master. |
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@reduxjs/toolkit](https://redux-toolkit.js.org) ([source](https://togithub.com/reduxjs/redux-toolkit)) | [`1.6.1` -> `1.6.2`](https://renovatebot.com/diffs/npm/@reduxjs%2ftoolkit/1.6.1/1.6.2) | [![age](https://badges.renovateapi.com/packages/npm/@reduxjs%2ftoolkit/1.6.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@reduxjs%2ftoolkit/1.6.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@reduxjs%2ftoolkit/1.6.2/compatibility-slim/1.6.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@reduxjs%2ftoolkit/1.6.2/confidence-slim/1.6.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>reduxjs/redux-toolkit</summary> ### [`v1.6.2`](https://togithub.com/reduxjs/redux-toolkit/releases/v1.6.2) [Compare Source](https://togithub.com/reduxjs/redux-toolkit/compare/v1.6.1...v1.6.2) This release fixes several small issues with RTK Query, as well as a regression in the `createAsyncThunk` types and an issue with sourcemap URLs. #### Changelog ##### RTK Query Fixes The `isLoading` flag should only ever be `true` on the first run of a hook, but would sometimes briefly flip to `true` on later calls. That should now stay the correct value. `fetchBaseQuery` should now work properly when used in conjunction with `node-fetch`. The `BaseQueryApi` object now correctly includes the `extra` argument that was provided when configuring the thunk middleware, if any. ##### Other Fixes Sourcemap URLs should now be correct, especially for the CommonJS build artifacts. `createAsyncThunk`'s types have been updated to correctly infer return values when working with enums. Lots of assorted docs tweaks and updates! #### What's Changed - Add extra to BaseQueryApi by [@​ricksanchez](https://togithub.com/ricksanchez) in [reduxjs/redux-toolkit#1378 - fix: point sourceMappingURL to correct sourcemaps in build artifacts by [@​jawadsh123](https://togithub.com/jawadsh123) in [reduxjs/redux-toolkit#1459 - fix: `createAsyncThunk` union return values fall back to allowing only single member by [@​phryneas](https://togithub.com/phryneas) in [reduxjs/redux-toolkit#1449 - fix `fetchBaseQuery` for usage with `node-fetch` by [@​phryneas](https://togithub.com/phryneas) in [reduxjs/redux-toolkit#1473 - fix "isLoading briefly flips back to `true`" [#​1519](https://togithub.com/reduxjs/redux-toolkit/issues/1519) by [@​phryneas](https://togithub.com/phryneas) in [reduxjs/redux-toolkit#1520 **Full Changelog**: reduxjs/redux-toolkit@v1.6.1...v1.6.2 </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/ttbud/ttbud).
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@reduxjs/toolkit](https://redux-toolkit.js.org) ([source](https://togithub.com/reduxjs/redux-toolkit)) | [`1.6.1` -> `1.6.2`](https://renovatebot.com/diffs/npm/@reduxjs%2ftoolkit/1.6.1/1.6.2) | [![age](https://badges.renovateapi.com/packages/npm/@reduxjs%2ftoolkit/1.6.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@reduxjs%2ftoolkit/1.6.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@reduxjs%2ftoolkit/1.6.2/compatibility-slim/1.6.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@reduxjs%2ftoolkit/1.6.2/confidence-slim/1.6.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>reduxjs/redux-toolkit</summary> ### [`v1.6.2`](https://togithub.com/reduxjs/redux-toolkit/releases/v1.6.2) [Compare Source](https://togithub.com/reduxjs/redux-toolkit/compare/v1.6.1...v1.6.2) This release fixes several small issues with RTK Query, as well as a regression in the `createAsyncThunk` types and an issue with sourcemap URLs. #### Changelog ##### RTK Query Fixes The `isLoading` flag should only ever be `true` on the first run of a hook, but would sometimes briefly flip to `true` on later calls. That should now stay the correct value. `fetchBaseQuery` should now work properly when used in conjunction with `node-fetch`. The `BaseQueryApi` object now correctly includes the `extra` argument that was provided when configuring the thunk middleware, if any. ##### Other Fixes Sourcemap URLs should now be correct, especially for the CommonJS build artifacts. `createAsyncThunk`'s types have been updated to correctly infer return values when working with enums. Lots of assorted docs tweaks and updates! #### What's Changed - Add extra to BaseQueryApi by [@​ricksanchez](https://togithub.com/ricksanchez) in [reduxjs/redux-toolkit#1378 - fix: point sourceMappingURL to correct sourcemaps in build artifacts by [@​jawadsh123](https://togithub.com/jawadsh123) in [reduxjs/redux-toolkit#1459 - fix: `createAsyncThunk` union return values fall back to allowing only single member by [@​phryneas](https://togithub.com/phryneas) in [reduxjs/redux-toolkit#1449 - fix `fetchBaseQuery` for usage with `node-fetch` by [@​phryneas](https://togithub.com/phryneas) in [reduxjs/redux-toolkit#1473 - fix "isLoading briefly flips back to `true`" [#​1519](https://togithub.com/reduxjs/redux-toolkit/issues/1519) by [@​phryneas](https://togithub.com/phryneas) in [reduxjs/redux-toolkit#1520 **Full Changelog**: reduxjs/redux-toolkit@v1.6.1...v1.6.2 </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/ttbud/ttbud).
Fixes #1154
looks like all our sourceMaps have been referring to non-existing
module.ts
andmodule.js.map
since the esbuild migrationThanks to @many20 for his analysis here
diff in
dist
after this change