Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export RetryOptions interface from retry.ts #1751

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

colemars
Copy link
Contributor

@colemars colemars commented Nov 16, 2021

fixes re-exporting a typed retry wrapped baseQuery when tsConfig.declaration = true.

Specifically resolves error:

Exported variable '{retry_wrapped_basequery}' has or is using name 'StaggerOptions' from external module "*/node_modules/@reduxjs/toolkit/dist/query/retry" but cannot be named.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fe367a2:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration

@netlify
Copy link

netlify bot commented Nov 16, 2021

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: b340dd8

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/619abaa800c24e0008166206

😎 Browse the preview: https://deploy-preview-1751--redux-starter-kit-docs.netlify.app

@colemars colemars changed the title export StaggerOptions interface from retry.js export StaggerOptions interface from retry.ts Nov 16, 2021
Copy link
Member

@msutkowski msutkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me. @phryneas or @markerikson should this point against master or v1.7 integration?

@phryneas
Copy link
Member

Generally fine with me, but I'd suggest we rename it to RetryOptions before that.

@msutkowski msutkowski changed the title export StaggerOptions interface from retry.ts export RetryOptions interface from retry.ts Nov 21, 2021
@msutkowski msutkowski changed the base branch from master to v1.7.0-integration November 22, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants