Test with multiple TypeScript minor versions in CI #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-starter-kit-docs ready! Built with commit ec24833 https://deploy-preview-217--redux-starter-kit-docs.netlify.com |
|
Seems pretty straightforward, and the Travis run for this PR definitely ran for each of those. Anything else needed to tweak this? |
|
Oops the |
|
The multiple TypeScript versions are being installed properly now, but the type tests fail on TypeScript 3.6. Should we try to fix it with this PR or use 3.5 as the max for now? |
|
Merge down from master - I merged in #215 , which should hopefully fix that. |
|
Yep, that passes now. Should be good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216