Fix #212 #214 #215
Fix #212 #214 #215
Conversation
|
Deploy preview for redux-starter-kit-docs ready! Built with commit 5db52ae https://deploy-preview-215--redux-starter-kit-docs.netlify.com |
| @@ -13,8 +13,8 @@ export type IsUnknown<T, True, False = never> = unknown extends T | |||
| : False | |||
|
|
|||
| export type IsEmptyObj<T, True, False = never> = T extends any | |||
There was a problem hiding this comment.
This is what I'm most concerned with. I believe this should be good to find really empty objects (the one before also matched objects with only optional properties), but I'm not 100% sure I'm not missing something.
There was a problem hiding this comment.
Your intuition is right! As far as I know, that's the most reliable way to match an empty object. {} is very tricky, since it doesn't really mean empty object. 😉
There was a problem hiding this comment.
Thanks a lot, that gives me some assurance :)
There was a problem hiding this comment.
The empty object detection looks good to me too. keyof T extends never is the most reliable way to ensure that the type has no keys.
|
Great, thanks! Out of curiosity for the still mostly-TS-clueless: any chance you could walk through how you went about debugging this problem? |
|
Hm, that failing build was to be expected (although it funnily doesn't fail on my local system, but I am switching between TS versions like crazy...). @markerikson, would you be okay if I added an any-cast in that failing line? |
I went to the I'm sure there are more elegant solutions to debug that, but that dumb way is working pretty well 😄 |
|
Ah, ye olde "brute force logging" approach :) Yeah, I'm okay with whatever works to actually resolve the problem. |
|
Argh, failing due to prettier issues. I really have to stop procastinating, I'll fix that up tomorrow. Alternatively, @markerikson could you please just push a prettier fix? |
|
At work atm, but yeah, will do so later. Also, Y U NO PRETTIER AUTOFORMAT ON SAVE?!?!? |
Not my work laptop, and vscode defaults to some other autoformat behaviour than prettier. But it does something. So I always forget to install the plugin, because it looks right. Fixed that on two machines and today, wrote the fix on my third machine :D |
|
Thanks for the fast solution! |
This should fix a bug with TS3.6 found in #212 and the bug reported in #214.
This should be working fine, but I'm currently preparing a conference talk, so I don't have the time to test this super-excessively and the bug fix for #214 is something I'm not feeling 100% sure of if I did everything right.
@dragomirtitian, could I ask you to take a look that I didn't do anything incredibly stupid there?