Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop pre-TS-4.1 types and workarounds #2249

Merged
merged 2 commits into from Apr 17, 2022
Merged

drop pre-TS-4.1 types and workarounds #2249

merged 2 commits into from Apr 17, 2022

Conversation

phryneas
Copy link
Member

No description provided.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 04a9799:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

@netlify
Copy link

netlify bot commented Apr 17, 2022

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 04a9799
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/625c51419f3ade0008a6efcc
😎 Deploy Preview https://deploy-preview-2249--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@markerikson
Copy link
Collaborator

Size check fails with:

 npm ERR! While resolving: rtk-monorepo@undefined
npm ERR! Found: eslint@7.32.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^7.25.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^5.0.0 || ^6.0.0" from @typescript-eslint/parser@2.34.0
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   peer @typescript-eslint/parser@"2.x" from eslint-config-react-app@5.2.1
npm ERR!   node_modules/eslint-config-react-app
npm ERR!     dev eslint-config-react-app@"^5.0.1" from the root project
npm ERR!   peer @typescript-eslint/parser@"^2.0.0" from @typescript-eslint/eslint-plugin@2.34.0
npm ERR!   node_modules/@typescript-eslint/eslint-plugin
npm ERR!     peer @typescript-eslint/eslint-plugin@"2.x" from eslint-config-react-app@5.2.1
npm ERR!     node_modules/eslint-config-react-app
npm ERR!       dev eslint-config-react-app@"^5.0.1" from the root project

Actual code changes seem reasonable, though.

@phryneas
Copy link
Member Author

That's because it uses npm. I've filed an issue over there and will merge this.
andresz1/size-limit-action#77

@phryneas phryneas merged commit 48689d4 into master Apr 17, 2022
phryneas added a commit that referenced this pull request Apr 18, 2022
* drop pre-4.1 type compatibility hack

* update test matrix, remove pre41 annotations
phryneas added a commit that referenced this pull request Apr 18, 2022
@phryneas
Copy link
Member Author

phryneas commented Jul 3, 2022

We'll have to cherry-pick this over into the 1.9 integration branch and then merge #2276

phryneas added a commit that referenced this pull request Jul 8, 2022
* drop pre-4.1 type compatibility hack

* update test matrix, remove pre41 annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants