Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2448): remove abort controller polyfill #2518

Conversation

JulienKode
Copy link
Contributor

@JulienKode JulienKode commented Jul 16, 2022

Description

In this PR we remove abort controller #2448

Where should I add in the docs that ?

  • For people that are using redux with a node.js server they:
    • need node.js 15 or have to polyfill AbortController

I'll update specs and add docs if we are ok

@JulienKode JulienKode changed the title fix(2448): remove abort controller fix(2448): remove abort controller polyfill Jul 16, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 16, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c23f7eb:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@netlify
Copy link

netlify bot commented Jul 16, 2022

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit c23f7eb
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/64ea67a0bb00f20008b9d94f
😎 Deploy Preview https://deploy-preview-2518--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@phryneas
Copy link
Member

Let's target that for a 2.0 release :)

@phryneas phryneas added this to the 2.0 milestone Jul 22, 2022
@JulienKode
Copy link
Contributor Author

@phryneas @markerikson let me know if I need to do any changes

@markerikson markerikson changed the base branch from master to v2.0-integration August 26, 2023 20:43
@markerikson markerikson force-pushed the fix/2448-remove-abort-controller branch from 0795484 to c23f7eb Compare August 26, 2023 20:59
@markerikson markerikson merged commit 08f3892 into reduxjs:v2.0-integration Aug 26, 2023
22 checks passed
@markerikson
Copy link
Collaborator

Belated, but thank you!

@JulienKode
Copy link
Contributor Author

JulienKode commented Sep 3, 2023

Thanks for merging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants