correctly infer dispatch from provided middlewares

[phryneas]

So this is my first attempt at solving #289.

Still a bit rough around the edges, but that's it for today.

• feature itself is working
• type documentation
• skip tests using as const in TS 3.3
• update typescript usage documentation

[netlify]

Deploy preview for redux-starter-kit-docs ready!

Built with commit 771d393

https://deploy-preview-304--redux-starter-kit-docs.netlify.com

[markerikson]

whimper :)

[phryneas]

Yeah, wanna REALLY hurt? Take a look at the implementation of Unshift ;)

Here, I had the choice between

• make getDefaultMiddleware always return [ThunkMiddleware], which is untrue (but would make stuff soooo much simpler!)
• create a type with one case for every possible combination of thunk, immutableCheck and serializableCheck (I had this in for a while)
• this one: create the tuple of length 0 to 3, and one check per possible configuration option. The only way to make a tuple longer in TS is currently to prepend values, to I'm starting with the empty tuple [] and prepending the three middlewares depending on their configuration value from the innermost to the outermost Unshift. At least it doesn't repeat itself too much 🤷‍♂️

[markerikson]

So now what happens if we add another entry to getDefaultMiddleware?

[phryneas]

This way: another level of Unshift, essentially two more lines. I might still extract the types in there out, that will make it more readable.

The way I had it before? Go from 3! cases to 4! cases.

Problem is: now that the Dispatch type relies on the value of middleware, getDefaultMiddleware needs to return it's value accurately.

Although I can think of a fourth way right now: instead of the tuple, it could also just return an array with specific values, as right now the order of middlewares is not taken into account.

That might be simpler to type - it was just not possible with an earlier implementation of DispatchForMiddlewares. I'll investigate that tomorrow.

[phryneas]

Okay, it worked out - that's much simpler now.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 771d393:

Sandbox	Source
optimistic-galois-xsdbc	Configuration
dank-https-c0pm2	Configuration

[phryneas]

Okay, documentation is updated, too. Could you please give this a look @markerikson ? :)

[markerikson]

Awright, putting this in.