Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slices overload to configureStore #4042

Closed
wants to merge 10 commits into from
Closed

Conversation

EskiMojo14
Copy link
Collaborator

No description provided.

Copy link

codesandbox bot commented Jan 5, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 97be0ce
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/65c16e9dfd54ac0008cf7a22
😎 Deploy Preview https://deploy-preview-4042--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Jan 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 97be0ce:

Sandbox Source
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

Copy link

github-actions bot commented Feb 5, 2024

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit (modern.mjs) 4.2 KB (+0.05% 🔺)
1. entry point: @reduxjs/toolkit/query (modern.mjs) 4.23 KB (+0.21% 🔺)
1. entry point: @reduxjs/toolkit/query/react (modern.mjs) 13.47 KB (+0.03% 🔺)
2. entry point: @reduxjs/toolkit (without dependencies) (modern.mjs) 812 B (+0.87% 🔺)
1. entry point: @reduxjs/toolkit (cjs, production.min.cjs) 14.1 KB (+0.16% 🔺)
1. entry point: @reduxjs/toolkit/react (cjs, production.min.cjs) 14.21 KB (+0.11% 🔺)
1. entry point: @reduxjs/toolkit/query (cjs, production.min.cjs) 21.99 KB (+0.43% 🔺)
1. entry point: @reduxjs/toolkit/query/react (cjs, production.min.cjs) 23.89 KB (+0.07% 🔺)
2. entry point: @reduxjs/toolkit (without dependencies) (cjs, production.min.cjs) 7.5 KB (+0.41% 🔺)
3. createAsyncThunk (.modern.mjs) 4.93 KB (+0.1% 🔺)
3. buildCreateSlice and asyncThunkCreator (.modern.mjs) 6.13 KB (-0.12% 🔽)
3. createEntityAdapter (.modern.mjs) 5.18 KB (+0.14% 🔺)
3. configureStore (.modern.mjs) 5.8 KB (+6.72% 🔺)
3. combineSlices (.modern.mjs) 4.78 KB (+0.15% 🔺)
3. createDynamicMiddleware (.modern.mjs) 4.49 KB (+0.11% 🔺)
3. createDynamicMiddleware (react) (.modern.mjs) 4.58 KB (+0.09% 🔺)
3. createListenerMiddleware (.modern.mjs) 5.37 KB (-0.02% 🔽)
3. createApi (.modern.mjs) 13.8 KB (-0.01% 🔽)
3. createApi (react) (.modern.mjs) 15.42 KB (+0.02% 🔺)
3. fetchBaseQuery (.modern.mjs) 5.08 KB (+0.04% 🔺)

@EskiMojo14
Copy link
Collaborator Author

closing, as this isn't possible without an overload, and the decrease in UX for reported errors isn't worth it when the user can just call configureStore({ reducer: combineSlices(...slices) }).

@EskiMojo14 EskiMojo14 closed this Jun 19, 2024
@EskiMojo14 EskiMojo14 deleted the configurestore-slices branch June 19, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant