Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size-limit config #4415

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Fixes size-limit config to monitor bundle size changes in preparation for any potential changes we'll have to make to migrate to React 19.

Copy link

codesandbox bot commented May 16, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented May 16, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit c107e68
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/667f3aae5ef83c00081e3b33
😎 Deploy Preview https://deploy-preview-4415--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented May 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c107e68:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@EskiMojo14
Copy link
Collaborator

For what it's worth, I don't think we actually want size info for every single entry point and export possible. We intentionally only measure entry points and exports we're actually concerned about the size for.

It's less of an issue since we filter out unchanged entries, but it still feels a little spammy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants