Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaceReducer() should throw if argument is not a function #1318

Closed
gaearon opened this issue Jan 30, 2016 · 3 comments
Closed

replaceReducer() should throw if argument is not a function #1318

gaearon opened this issue Jan 30, 2016 · 3 comments
Labels
enhancement help wanted

Comments

@gaearon
Copy link
Contributor

gaearon commented Jan 30, 2016

This is an easy one, please feel free to send a PR.
We want to add a typeof check in replaceReducer just like we have when the store is created.
@neebz neebz mentioned this issue Jan 30, 2016
Closed
@Andersos Andersos mentioned this issue Jan 30, 2016
Closed
@Andersos
Copy link

Hello @gaearon, I tried making a pull request for this in #1320 . Do you want me to also try and make a test for the case?

@gaearon
Copy link
Contributor Author

gaearon commented Jan 30, 2016

Thank you! Yes, tests are necessary.

@JamieDixon JamieDixon mentioned this issue Jan 30, 2016
Closed
@dzhiriki dzhiriki mentioned this issue Jan 30, 2016
Merged
@gaearon
Copy link
Contributor Author

gaearon commented Jan 30, 2016

This is now fixed by #1321, thanks @dzhiriki!

@gaearon gaearon closed this as completed Jan 30, 2016
brandoncroberts pushed a commit to brandoncroberts/redux that referenced this issue Oct 13, 2023
@phryneas
remove originalArgs from the mutation slice (reduxjs#1318)
b7731ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Andersos @gaearon